Fix enum column conversion by "instantiating" Enum#201
Closed
thejcannon wants to merge 1 commit intographql-python:masterfrom
thejcannon:enums_support
Closed
Fix enum column conversion by "instantiating" Enum#201thejcannon wants to merge 1 commit intographql-python:masterfrom thejcannon:enums_support
thejcannon wants to merge 1 commit intographql-python:masterfrom
thejcannon:enums_support
Conversation
jnak
reviewed
Apr 9, 2019
Collaborator
jnak
left a comment
There was a problem hiding this comment.
Looks good! I just had a couple of very minor comments.
Author
|
Once this gets merged in, I wouldn't mind resolving the conflicts in #165 with my changes. |
Collaborator
|
@thejcannon After commented on this PR, I caught up with this one #98. Do you expect your PR to conflict with that one as well? |
Author
|
Actually I looked at #165 for this issue and made this: https://github.com/thejcannon/graphene-sqlalchemy/commit/737e288c67fbb875de371ecea23d67e4cdce6156 So you could close both of those once that PR is made/merged. |
Member
Collaborator
|
Closing since #210 got merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196 and #199.
See also graphql-python/graphene#932